Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22781 Adding support for constant denominators #3336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

younies
Copy link
Member

@younies younies commented Jan 19, 2025

Adding support for constant denominators

  • Introduced a new field for constant denominators in MeasureUnitImpl.
  • Added methods to set and retrieve constant denominators in MeasureUnit.
  • Updated parsing logic to handle unit constants correctly.
  • Enhanced unit tests to cover new functionality, including constant denominator scenarios.
  • Improved code readability and consistency across MeasureUnit and SingleUnitImpl classes.

TODO in the following PRs

  1. Add support to unit constant during units conversion.
  2. Add support to unit constant during units formatting.

Checklist

  • Required: Issue filed: ICU-22781
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies younies requested a review from richgillam January 19, 2025 23:30
@younies younies changed the title ICU-22781 Enhance MeasureUnit functionality by adding support for constant denominators ICU-22781 Adding support for constant denominators Jan 20, 2025
younies added a commit to younies/icu that referenced this pull request Jan 20, 2025
@younies younies force-pushed the java-parse-constants branch from 3fdec81 to 9e03b30 Compare January 20, 2025 11:31
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies marked this pull request as ready for review January 20, 2025 11:32
@younies younies requested a review from sffc January 20, 2025 11:33
@younies younies force-pushed the java-parse-constants branch from 1e8b0cb to 88a6fc1 Compare January 20, 2025 13:40
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant